Complete quoting for parameters of some CMake commands. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commands A wiki article pointed out that whitespace will only be preserved for parameters in CMake commands if passed strings will be appropriately quoted or escaped. http://cmake.org/Wiki/CMake/Language_Syntax#CMake_splits_arguments_unless_you_use_quotation_marks_or_escapes. Quoting was added so that more places should also handle file names correctly which contain space characters or semicolons eventually. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
| VERBATIM) | ||
| else() | ||
| file(WRITE ${CMAKE_SOURCE_DIR}/src/gen_version.h | ||
| file(WRITE "${gv}" | ||
| "#ifndef GEN_VERSION_H\n" | ||
| "#define GEN_VERSION_H\n" | ||
| "#define APP_VERSION \"3.0.1\"\n" |
There was a problem hiding this comment.
Is this "3.0.1" supposed to be the application version number? eg so 3.0.1 is a bug in our source, and we should update it to 3.2.x as appropriate
There was a problem hiding this comment.
I am unsure in which application release my update suggestion will be integrated.
There was a problem hiding this comment.
No worries. This version number doesn't really matter that much; it's updated more conscientiously in the release branches. I think it would make most sense to replace it by some '999' dummy version number, just like it's done when the .git directory is found.
MKleusberg
added a commit
that referenced
this pull request
Aug 2, 2014
…f_some_CMake_commands Complete quoting for parameters of some CMake commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A wiki article pointed out that whitespace will only be preserved for parameters in CMake commands if passed strings will be appropriately quoted or escaped.
Quoting can be added so that more places should also handle file names correctly which contain semicolons eventually.